Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dump oauth1_token.json oauth2_token.json together, and dump them as string #4

Closed
yihong0618 opened this issue Sep 26, 2023 · 2 comments · Fixed by #5
Closed

Comments

@yihong0618
Copy link
Contributor

Thanks for your repo~
For some repos like https://github.com/yihong0618/running_page
we use GitHub Actions secret to daily sync the data, so maybe we can make this token something like base64 it to a string, and save it in the secret, we can load them from method like garth.resume_from_string(str)

I can open a PR to support it

@matin
Copy link
Owner

matin commented Sep 26, 2023

Love what you're building!

Would a JSON serialized string be sufficient?

I was thinking we could add Client.dumps() and Client.loads(tokens). That way we have symmetry with the current Client.dump() and Client.load() methods.

@yihong0618
Copy link
Contributor Author

I wonder for GitHub Actions base64 string is better, will open one PR, let us discuss there later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants