Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for DeviceParse new structure (discussion) #6802

Closed
sanchezzzhak opened this issue Jul 19, 2021 · 2 comments
Closed

Improvements for DeviceParse new structure (discussion) #6802

sanchezzzhak opened this issue Jul 19, 2021 · 2 comments

Comments

@sanchezzzhak
Copy link
Collaborator

sanchezzzhak commented Jul 19, 2021

add the type to the brand definition array
example new structure

Brand Name:
 regex: 'common regex'
 device: 'smartphone'
 models:
    - device: 'feature phone'
      models:
         - regex: ''
           model: 
   -  device: 'tablet'
      models:
         - regex: ''
           model:
   # etc.. 
   
   # The current syntax is also left
   - regex: ''
     device: 'phablet'
     model: ''

!!! Risks:
this will break a lot of ports, but it will reduce 1400~ lines in the mobiles.yml

@Selena20191

This comment has been minimized.

@sanchezzzhak
Copy link
Collaborator Author

I would really like to do this, but I'm afraid that updating in other program-languages will be very difficult or long updates.
maybe later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants