Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Samsung Galaxy S22 device detection to etienne-martin/device-detector-js #7239

Closed
zetti-caletti opened this issue Sep 16, 2022 · 4 comments

Comments

@zetti-caletti
Copy link

Galaxy S22 device detection is supported in matomo-org/device-detector but not in etienne-martin/device-detector-js.

Please sync. Thank you :)

@sgiehl
Copy link
Member

sgiehl commented Oct 10, 2022

Hi @zetti-caletti
Sorry for the delay in answering. As this is the source repository of the definitions, you may want to create such a request in etienne-martin/device-detector-js instead.
We can't sync anything there.

@zetti-caletti
Copy link
Author

Sorry I misunderstood it. When creating an issue at etienne-martin/device-detector-js it says "⚠️ Missing/incorrect detections should be reported at https://github.com/matomo-org/device-detector/issues instead of this repo."
Thought that the author of the other library is someone from matomo who is able to sync or I don't know.^^

@etienne-martin
Copy link
Contributor

Hi @sgiehl, I've been busy with other stuff that etienne-martin/device-detector-js has fallen behind matomo-org/device-detector quite a bit.

I can maybe remove the issue template to avoid sending false positives your way, what do you think?

@sgiehl
Copy link
Member

sgiehl commented Oct 11, 2022

@etienne-martin there hadn't been too many false positives yet, so all good from our side.
Haven't had a look how your fork uses the definitions, but maybe it would be possible to kind of sync them using a github action or similar, so the don't fall behind? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants