Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaptiveNetworkSupport agent not all identified #7541

Closed
malle-pietje opened this issue Dec 20, 2023 · 3 comments
Closed

CaptiveNetworkSupport agent not all identified #7541

malle-pietje opened this issue Dec 20, 2023 · 3 comments

Comments

@malle-pietje
Copy link

Hi, thanks for this package, it works great for us in a number of applications!

One of our applications is a WiFi captive portal where we extract the device properties for reporting/analytics purposes.

We see a lot of iOS devices using the following user-agents which aren't identified because the only pattern I could find is CaptiveNetworkSupport-416 wispr:

CaptiveNetworkSupport-346.50.1 wispr   
CaptiveNetworkSupport-355.200.27 wispr 
CaptiveNetworkSupport-355.261.1 wispr  
CaptiveNetworkSupport-355.270.2 wispr  
CaptiveNetworkSupport-355.60.1 wispr   
CaptiveNetworkSupport-390.40.1 wispr   
CaptiveNetworkSupport-390.60.1 wispr   
CaptiveNetworkSupport-407.40.1 wispr   
CaptiveNetworkSupport-416 wispr        
CaptiveNetworkSupport-416.30.2 wispr   
CaptiveNetworkSupport-418 wispr        
CaptiveNetworkSupport-418.80.2 wispr   
CaptiveNetworkSupport-428.0.0.0.1 wispr
CaptiveNetworkSupport-428.120.3 wispr  
CaptiveNetworkSupport-428.140.2 wispr  
CaptiveNetworkSupport-441 wispr        
CaptiveNetworkSupport-443.100.2 wispr  
CaptiveNetworkSupport-443.120.3 wispr  
CaptiveNetworkSupport-443.40.1 wispr   
CaptiveNetworkSupport-457 wispr        
CaptiveNetworkSupport-461.40.3 wispr   
CaptiveNetworkSupport-461.62.1 wispr   
CaptiveNetworkSupport-461.80.2 wispr 

Would it be possible add a regex that catches these? We wouldn't need to know versions, results like this would be perfectly fine:

    name: iOS
    short_name: IOS
    version:
    platform:
    family: iOS
@malle-pietje
Copy link
Author

My AI friend came up with this regex ((I'm not that comfortable with regex patterns myself 😉) that should catch the above strings:

"CaptiveNetworkSupport-\d+(?:\.\d+)*\s+wispr"

@liviuconcioiu
Copy link
Collaborator

It's already detected:

cbb16c1
https://devicedetector.lw1.at/CaptiveNetworkSupport-461.80.2%20wispr

You should use the latest version.

@malle-pietje
Copy link
Author

Ah, my bad. We were stuck on v4.3.1 due to older PHP versions we needed to support, we've now bumped that to v5 and hopefully we can soon move on to 6.

Nice and useful tool by the way: https://devicedetector.lw1.at/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants