Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of dynamic property MatomoTracker::$currentTs is deprecated #129

Closed
dkossako opened this issue Mar 1, 2024 · 5 comments · Fixed by #131
Closed

Creation of dynamic property MatomoTracker::$currentTs is deprecated #129

dkossako opened this issue Mar 1, 2024 · 5 comments · Fixed by #131

Comments

@dkossako
Copy link

dkossako commented Mar 1, 2024

There are some deprecations in latest version of tracker:

Creation of dynamic property MatomoTracker::$currentTs is deprecated

Also other properties are affected:

  • MatomoTracker::$forcedVisitorId
  • MatomoTracker::$requestTimeout
  • MatomoTracker::$configCookiePath
  • MatomoTracker::$visitCount
  • MatomoTracker::$ecommerceLastOrderTimestamp
  • MatomoTracker::$doBulkRequests
  • MatomoTracker::$incomingTrackerCookies
        $this->currentTs = time();
        $this->createTs = $this->currentTs;
        $this->visitCount = 0;
        $this->currentVisitTs = false;
        $this->lastVisitTs = false;
        $this->ecommerceLastOrderTimestamp = false;
@michalkleiner
Copy link
Contributor

Thanks for raising the issue @dkossako, we will look into adding class variables for the dynamic properties.

@michalkleiner
Copy link
Contributor

Can you confirm what version of PHP you're running the tracker on? Is it 8.2?

@dkossako
Copy link
Author

8.3.3

@lutdev
Copy link
Contributor

lutdev commented May 10, 2024

@sgiehl you have merged my PR, can we tag the new version and close this issue?)

@michalkleiner
Copy link
Contributor

@lutdev let's do it together with #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants