Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into master. #55

Closed
d4rken opened this issue May 5, 2015 · 2 comments
Closed

Merge develop into master. #55

d4rken opened this issue May 5, 2015 · 2 comments

Comments

@d4rken
Copy link
Member

d4rken commented May 5, 2015

@dotsbb I think we can merge the current develop branch into master.
I've been using it in production for a month now and I'm satisfied.

New people looking to integrate Piwik into their app shouldn't use the build from current master branch.

We could increase the version to 0.0.2 as there were some major changes.

When merging we should also make sure the .jar file is either updated or removed to prevent confusion.

Not sure whats going on with #31

@dotsbb
Copy link
Member

dotsbb commented May 6, 2015

@d4rken It's nice to hear from you. I'm very grateful for your feedback!

For sure, it's good time to merge dev into master.
I would rather bump dev vesrion to 0.1.0. Current master should be 0.0.2 because it's already ahead https://github.com/piwik/piwik-sdk-android/tree/v0.0.1 by ~50 commits.

Before we merge it I think it would be nice to have following list done:

I'll try to find some spare time to do it on weekends.

@d4rken
Copy link
Member Author

d4rken commented May 6, 2015

👍 sounds good.

We could attach the changelog to releases.
i.e.
Read commits between current tag and previous tag, create release for current tag, write changelog into its description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants