Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back real device model in user agent feature #330

Merged
merged 1 commit into from Mar 3, 2020

Conversation

hcbarry
Copy link
Contributor

@hcbarry hcbarry commented Feb 11, 2020

There was a feature replacing generic string in the user agent with the real device model (#253), which was removed in WKWebView migration (#308). It would be great to have it back if possible :)

@brototyp
Copy link
Member

Hey @hcbarry, thanks for the PR! Looks straight forward.
Looks like something froze on travis. Should we just restart the build there?

@hcbarry
Copy link
Contributor Author

hcbarry commented Feb 25, 2020

@brototyp sure! but I'm not seeing the restart build button, which may because of the permission setting, please just restart the build :)

@brototyp
Copy link
Member

Oh, dang. I can't see it either. I thought that's because it's a PR from your repository. Can you have a look if you have a button in the "More Options" menu?

If that doesn't work, I guess we need to add a dummy commit 🤔

@hcbarry hcbarry closed this Feb 27, 2020
@hcbarry hcbarry reopened this Feb 27, 2020
@hcbarry
Copy link
Contributor Author

hcbarry commented Feb 27, 2020

More Option menu has only one requests button, but closing and then reopening did trigger a new build!

@brototyp
Copy link
Member

More Option menu has only one requests button, but closing and then reopening did trigger a new build!

Weird! Thanks for checking that!

@brototyp-bot
Copy link

1 Warning
⚠️ Are there any changes that should be explained in the README.md?

Generated by 🚫 Danger

@hcbarry hcbarry closed this Feb 27, 2020
@hcbarry hcbarry reopened this Feb 27, 2020
@hcbarry
Copy link
Contributor Author

hcbarry commented Feb 27, 2020

Hmm it's strange that all tests passed on my machine but failed on travis, I'm triggering another build to see if there's a different result

@brototyp
Copy link
Member

Hm. It might be some outdated Travis Setup. I'll have a look later.

@hcbarry
Copy link
Contributor Author

hcbarry commented Feb 27, 2020

Very much appreciated!

@brototyp
Copy link
Member

brototyp commented Mar 1, 2020

Hey @hcbarry, I just updated the ci environment (See #332). It was a little outdated and had a few smaller issues. Can you merge/rebase development? Maybe that helps here as well.

@hcbarry
Copy link
Contributor Author

hcbarry commented Mar 2, 2020

Finally passed 🎉🎉🎉

@brototyp
Copy link
Member

brototyp commented Mar 3, 2020

Thanks for your effort!

@brototyp brototyp merged commit c78b9e3 into matomo-org:develop Mar 3, 2020
@brototyp
Copy link
Member

brototyp commented Mar 3, 2020

I'll release this as part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants