Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show for plugins a flag indicating the php version compatibility status #10132

Open
hpvd opened this issue May 9, 2016 · 5 comments
Open

Show for plugins a flag indicating the php version compatibility status #10132

hpvd opened this issue May 9, 2016 · 5 comments
Labels
c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@hpvd
Copy link

hpvd commented May 9, 2016

Maybe a flag to which version of php a) piwik core and b) each plugin is compatible to / is tested with,
can be helpful

  • Should give a warning if the php version curently used is out of range of the ones supported
    • during installation of piwik itselve
    • during installation of plugins
  • could be used to very if everything (piwik core and plugins) is compatible before doing an upgrade of php (e.g. 5.5 to 5.6, or 5.6 to 7.0)
    e.g. via a function which simply reads these values from core and plugin and displays a list in piwiks backend
@hpvd
Copy link
Author

hpvd commented May 9, 2016

with this, one

  • would prevent problems with installation of piwik and plugins because of a too up to date version of php is used
  • would greatly reduce problems after php upgrades (one can check before..) and
  • could ask plugin developers if there is an update needed before getting into trouble...

@hpvd hpvd changed the title plugins: php compatible version flag core and plugins: flag for php version compatibility May 9, 2016
@tsteur
Copy link
Member

tsteur commented May 10, 2016

Plugin developers are supposed to define compatible Piwik and PHP versions in the plugin and we automatically disable a plugin when it is no longer compatible. The PHP version should be shown on the Marketplace and in the App Marketplace

@tsteur tsteur closed this as completed May 10, 2016
@tsteur tsteur added the answered For when a question was asked and we referred to forum or answered it. label May 10, 2016
@hpvd
Copy link
Author

hpvd commented May 10, 2016

Many thanks for getting back.

an example:
Just wanted to get some information: which plugins wouldn't work anymore if I updated php to v7.0.

Going to the place you described: could you please give me a hint where exactly I could get the necessary information?

Here is an example of a plugin made by piwik team:

2016-05-10_18h04_05

2016-05-10_18h04_20

2016-05-10_18h04_31

2016-05-10_18h04_42

2016-05-10_18h05_05

@hpvd
Copy link
Author

hpvd commented May 10, 2016

Other example:
I'm still running piwik 2.15
How could I be sure all plugins I need are already compatible to 2.16 ?

@tsteur
Copy link
Member

tsteur commented May 10, 2016

You're right, we are only showing it on https://plugins.piwik.org eg in http://plugins.piwik.org/VisitorGenerator

image

The reason we are not showing it is that basically all plugins without a notice are compatible with current Piwik and PHP version. As soon as an update of PHP or Piwik is needed we show an info box in the plugin explaining what needs to be updated. This doesn't help in a case like you mentioned though when you want to update PHP version.

With Piwik 3 we will show on https://plugins.piwik.org a select list where you can select Piwik 2 / 3 and then it shows compatible plugins. I will reopen the issue so we can information about required Piwik and PHP version in the Piwik App Marketplace.

@tsteur tsteur reopened this May 10, 2016
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. and removed answered For when a question was asked and we referred to forum or answered it. labels May 10, 2016
@mattab mattab added this to the 3.0.0 milestone May 27, 2016
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Dec 10, 2023
@mattab mattab changed the title core and plugins: flag for php version compatibility Show for plugins a flag indicating the php version compatibility status Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants