Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracked resolution of Mac Retina displays is wrong #10289

Closed
tsteur opened this Issue Jul 12, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@tsteur
Copy link
Member

commented Jul 12, 2016

It records res = 2560x1600 because window.devicePixelRatio = 2 and actual resolution is 1280x800. It should actually report 1280x800 because it does not show 2560x600, it only shows more pixels "per pixel". Similar issue might be for smartphones but haven't tested.

Related code: https://github.com/piwik/piwik/blob/2.16.1/js/piwik.js#L5022-L5024

@tsteur tsteur added the Bug label Jul 12, 2016

@tsteur

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2016

I think it is for mobile phones as well see #3416

Eg in case of iPhone 5 it would be more accurate to log 320x568 than 1136 x 640 because from a website point of view it is only 320x568px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.