Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header row in table with goals metrics visualisations isn't sticky making the report hard to impossible to use #19714

Open
tsteur opened this issue Sep 8, 2022 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.

Comments

@tsteur
Copy link
Member

tsteur commented Sep 8, 2022

I'm on /index.php?module=CoreHome&action=index&idSite=12&period=week&date=today#?idSite=1&period=month&date=2022-08-26&category=General_Actions&subcategory=General_Pages

Then I change visualisation to "Display a table with goal metrics".

Then I scroll down.

Expected: The header row stay on top always visible when scrolling down.

Actual: The header row becomes invisible once you scroll down too far.

Then the visualisation becomes almost impossible to use since you never really know which value is for what goal etc. In the regular Table view the header row remains sticky but not for this visualisation.

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Sep 8, 2022
@sgiehl
Copy link
Member

sgiehl commented Sep 8, 2022

@tsteur That is actually kind of expected behaviour. The problem is, that the sticky header doesn't work in combination with a x-scroll. So this should actually not only be an issue of the goal viz, but all reports that are wider then available space.

@tsteur tsteur changed the title Header row in table with goals metrics visualisations isn't sticky Header row in table with goals metrics visualisations isn't sticky making the report hard to impossible to use Sep 8, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Sep 9, 2022

To completely fix this, maybe we can use a bootstrap 5 library (https://examples.bootstrap-table.com/#extensions/sticky-header.html), but we have to convert the table js quite a bit.

@sgiehl
Copy link
Member

sgiehl commented Sep 9, 2022

@peterhashair Does that lib support having sticky header and a sticky first column?

@peterhashair
Copy link
Contributor

@sgiehl
Copy link
Member

sgiehl commented Sep 12, 2022

@peterhashair If you have a look at their implementation details, having sticky header and a sticky first column does not work there as well. At least it is no native support. They are using a sticky header only. The sticky first column is "simulated" by copying the full first column into a new table, that is then positioned absolute above the original table. The scrolling of both tables is then also synced using javascript.

That might be something we could also implement on our own. But iirc we didn't implement something like that initially, as it would be a lot more effort. See #18124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

No branches or pull requests

4 participants