Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also display icon for mobile apps (in addition to browsers) #19999

Open
Findus23 opened this issue Nov 13, 2022 · 0 comments
Open

Also display icon for mobile apps (in addition to browsers) #19999

Findus23 opened this issue Nov 13, 2022 · 0 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@Findus23
Copy link
Member

Matomo uses the output of DeviceDetector to also decide which icon to display for the browser. (The icons are from https://github.com/matomo-org/matomo-icons/)

/**
* Returns the path to the logo for the given browser
*
* First try to find a logo for the given short code
* If none can be found try to find a logo for the browser family
* Return unknown logo otherwise
*
* @param string $short Shortcode or name of browser
*
* @return string path to image
*/
function getBrowserLogo($short)

Since #16197 Matomo also supports clients that are not browsers, but the icon logic hasn't been updated for this yet.

While adding the icons to matomo-icons is simple, a solution needs to be found for adapting this code to also work with all clients like mobile apps

grafik
grafik

@Findus23 Findus23 added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Nov 13, 2022
@Findus23 Findus23 added this to the For Prioritization milestone Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

1 participant