Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New admin setting: Should admin users see the list of all users in Piwik? #2028

Closed
mattab opened this issue Jan 17, 2011 · 6 comments
Closed

New admin setting: Should admin users see the list of all users in Piwik? #2028

mattab opened this issue Jan 17, 2011 · 6 comments
Milestone

Comments

@mattab
Copy link
Member

@mattab mattab commented Jan 17, 2011

We got a few user requests from this, as it is causing confusion: why an admin user can see the list of all Piwik users?

Originally this is designed so that admin users can only assign permission to existing users, but not create users.

There are probably 2 ways to fix this issue:

  • either remove the ability for non super user to set permissions to view/admin a website
  • or add a General Settings option to Enable/Disable "Admin users can grant 'view' or 'admin' permissions to other users". This setting would affect the Users Manager UI, as well as all relevant functions in the API.

I'm not sure what would be the best way to handle this issue, without doing fine grained permission #1568 (as this seems to be the main request regarding user access, so not keen to make it generic at this stage).

@anonymous-piwik-user
Copy link

@anonymous-piwik-user anonymous-piwik-user commented Jan 18, 2011

I think it depends on how important it is for Piwik sites, if their admin users can control who can view their site or not or if it suffices if the super-user can control that. A third solution might be to add another property "visible" to the existing properties "view" and "admin" for a user. The super-user could then set users to "visible" for a certain site or all sites. A "visible" user would show up in the user settings of an admin for that site, so that he could set "view" or "admin" for that user. Non-"visible" users would not show up.
In our case an admin for a site mailed me and asked what those other users were that he could see. That is how I learned that admins can see other users. In some environments it's probably quite important that users (customers) are not able to see other users.

@mattab
Copy link
Member Author

@mattab mattab commented Jul 30, 2011

Ability to disable this was asked multiple times recently, it would be nice to fit this in 1.x

http://forum.piwik.org/read.php?2,79819 and http://forum.piwik.org/read.php?2,79864


How is possible to hide the "Users" tab (module=UsersManager) and disable completely this functionality for non-root users?

Some .ini variable? Any instructions for modifying the source code, if necessary?

@mattab
Copy link
Member Author

@mattab mattab commented Nov 3, 2011

Regrouped in this ticket: #1568

@anonymous-piwik-user
Copy link

@anonymous-piwik-user anonymous-piwik-user commented Jun 14, 2013

Hi,
In our environment we would like website admins not being able to view the list of users because they are from different organizations and it may expose privacy information disclosure.

@mattab
Copy link
Member Author

@mattab mattab commented Jun 18, 2013

This is a good request. If you need Professional help and would like to have this feature implemented please contact Pro Services at: http://piwik.org/consulting/#contact-consultant

@anonymous-piwik-user
Copy link

@anonymous-piwik-user anonymous-piwik-user commented Jun 9, 2014

I would like to see this also. Users should never really be able to see other users like this.

Replying to matt:

We got a few user requests from this, as it is causing confusion: why an admin user can see the list of all Piwik users?

Originally this is designed so that admin users can only assign permission to existing users, but not create users.

There are probably 2 ways to fix this issue:

  • either remove the ability for non super user to set permissions to view/admin a website
  • or add a General Settings option to Enable/Disable "Admin users can grant 'view' or 'admin' permissions to other users". This setting would affect the Users Manager UI, as well as all relevant functions in the API.

I'm not sure what would be the best way to handle this issue, without doing fine grained permission #1568 (as this seems to be the main request regarding user access, so not keen to make it generic at this stage).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.