Archiving task fails when tracking failures contain large number of URL params (notify tracking failures)

[tagleeson]

Expected Behavior

Archive task should complete successfully

Current Behavior

Archive task fails due to the following: parse_str(): Input variables exceeded 1000

Possible Solution

matomo/plugins/CoreAdminHome/Tasks.php

Line 216 in f29b990

$failures = $this->trackingFailures->getAllFailures();

<- this code could short-circuit to check the configuration before attempting to find the failures.

Steps to Reproduce (for Bugs)

1. Create a tracking failure on a URL with > 1000 parameters
2. Attempt to run archiving task

Context

Sometimes there are malicious attempts to access URLs with many parameters, which causes the archiving task to fail when it comes to report the tracking failures. Note that we do not want to increase the parameter limit as suggested, since this is a malicious attempt.

We currently have the configuration setting for notifying tracking failures turned off, but this doesn't fix the issue, as noted above, the code attempts to get the failures before checking the config. It would be nice as a stopgap to avoid the issue by having the configuration switched off.

Your Environment

• Matomo Version: 4.13.3

[sgiehl]

@tagleeson You could try if adding an error suppression (@) on this line would solve the issue:

matomo/core/Tracker/Failures.php

Line 165 in c973567

parse_str($failure['request_url'], $params);

The problem is that parse_str uses the php ini config max_input_vars and if the number of variables in the parsed string exeeds this number a warning is triggered and additional variables will be truncated. As this doesn't matter in this case, simply ignoring the warning might be fine.