Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete annotation feature is not translatable #20484

Closed
Chardonneaur opened this issue Mar 16, 2023 · 2 comments
Closed

Delete annotation feature is not translatable #20484

Chardonneaur opened this issue Mar 16, 2023 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@Chardonneaur
Copy link

Hi team,
When we hover the mouse on the bin of an annotation written and that we are in a language other than English, it shows the word "Delete" as a bubble.
I guess this translation key is not within weblate yet.

@Chardonneaur Chardonneaur added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Mar 16, 2023
@Findus23
Copy link
Member

It seems like here

<a class="delete-annotation" title="Delete">
<span class="icon-delete"></span>
</a>

it should be title="{{ 'Annotations_ClickToDelete'|translate }}" instead

@bx80
Copy link
Contributor

bx80 commented Mar 17, 2023

Thanks @Findus23 👍

I've put that fix in a PR and it will be in Matomo 5

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Mar 17, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Mar 17, 2023
@sgiehl sgiehl closed this as completed Mar 17, 2023
@sgiehl sgiehl changed the title Translation issue with the delete annotation feature Delete annotation feature is not translatable May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants