Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a website, it adds it twice instead of once #20838

Closed
Stan-vw opened this issue Jun 6, 2023 · 5 comments · Fixed by #20879
Closed

When adding a website, it adds it twice instead of once #20838

Stan-vw opened this issue Jun 6, 2023 · 5 comments · Fixed by #20879
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@Stan-vw
Copy link
Contributor

Stan-vw commented Jun 6, 2023

Sometimes when adding a new website, the website is added twice. This seems to happen somewhat frequently, and I haven't found a common cause.

It's pretty easy to just delete one, but it's quite confusing when you're not familiar with the bug.

Expected Behavior

When adding a website, it adds it just once.

Current Behavior

Sometimes it's added twice.

Possible Solution

Workaround: people can delete the second one.
Actual fix: it shouldn't happen in the first place

Steps to Reproduce (for Bugs)

Unsure

Your Environment

Cloud
MacOs

@Stan-vw Stan-vw added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jun 6, 2023
@bx80
Copy link
Contributor

bx80 commented Jun 11, 2023

Thanks for reporting this @Stan-vw, I wasn't able to easily reproduce this issue with some brief testing, so I'll assign it for prioritization where we can investigate in more depth.

@bx80 bx80 removed the To Triage An issue awaiting triage by a Matomo core team member label Jun 11, 2023
@bx80 bx80 added this to the For Prioritization milestone Jun 11, 2023
@sgiehl
Copy link
Member

sgiehl commented Jun 11, 2023

@Stan-vw could that be some sort of double click issue? Maybe the create button isn't locked and it's possible to send the same request multiple times...

@Stan-vw
Copy link
Contributor Author

Stan-vw commented Jun 11, 2023

@sgiehl I'm reasonably certain I didn't double click. Locking it after one click does sound logical to me, then again not a dev so I'm not sure what the best options are here.
@Javi-Ormaechea you've had this too iirc, any further details that you're aware of?

@sgiehl
Copy link
Member

sgiehl commented Jun 12, 2023

I just did a local test and the button seems no longer be disabled upon a click. This might be a regression of the vue migration. As least I think the button had been disabled before.
Anyway. Clicking the button 10 times creates 10 new sites. That should for sure be avoided by disabling the button. Should be an easy fix. Will have a quick look at it.

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jun 12, 2023
@sgiehl sgiehl self-assigned this Jun 12, 2023
@sgiehl sgiehl modified the milestones: For Prioritization, 5.0.0 Jun 12, 2023
@Javi-Ormaechea
Copy link

@Stan-vw I haven't had this (as far as I can remember)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants