Occasional Error message when Visitor Log is deactivate (regression)

[9joshua]

When the visitor log is deactivated for a website an error message can be seen at times...

In this particular case, the date range included the current date (related to live data?)

[michalkleiner]

Hi @9joshua, can you provide more details about when the error appears? Is it when viewing a particular report only, e.g. the Goal as in the picture, or it appears elsewhere too?

[9joshua]

@michalkleiner The issue affected another user and they were not able to reproduce it, nor was I.

[sgiehl]

Without looking too much into details I would assume this can happen here:
https://github.com/matomo-org/matomo/blob/5.x-dev/plugins/CoreHome/vue/src/ReportingPage/ReportingPage.vue#L276

If there are not visits, we check for raw data to consider which notification to show. If visits log is disabled that API method might throw an error, that is then possibly displayed.

Guess we need to check if visits log is enabled (piwik.visitorLogEnabled) or not before before calling this API method.

[9joshua]

This can be reproduced by:

• viewing a report that has no data
• for a site which has the visitor log disabled
• where the calendar period includes the current day (i.e. current month)

I think Matomo assumes that the disabling of the visit log produced the empty table, even if the reason is simply that no data exists for the requested table/period...