Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selection in Updater no longer works #20960

Closed
sgiehl opened this issue Jul 4, 2023 · 0 comments · Fixed by #21038
Closed

Language selection in Updater no longer works #20960

sgiehl opened this issue Jul 4, 2023 · 0 comments · Fixed by #21038
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Jul 4, 2023

Context

When a database update is required Matomo displays an update screen. By default the screen uses the browser language.

There is also a language drop down, which should allow to change the language of the screen.

image

Selecting another language, currently tries to save the selected language by posting a form to index.php?module=LanguagesManager&action=saveLanguage

As the updater might be performed without a session or login, this can result in an error screen, asking to login.

image

Expected Behavior

The language of the update screen can simply be changed by using the parameter &language=XX, so when choosing another language the parameter in url should be change/added.

Steps to Reproduce (for Bugs)

  1. Force update screen to display by changing the option value for version_Core to a value like 4.14.0
  2. Open Matomo
  3. Try to select another language

Your Environment

  • Matomo Version: 5.0.0-b4
  • PHP Version: 7.2
  • Server Operating System: Linux
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jul 4, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant