Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolution graph in acquisitions overview not showing data #21051

Closed
tsteur opened this issue Jul 22, 2023 · 5 comments · Fixed by #21165
Closed

Evolution graph in acquisitions overview not showing data #21051

tsteur opened this issue Jul 22, 2023 · 5 comments · Fixed by #21165
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Jul 22, 2023

See below screenshot on latest 4.X beta where it shows no data and metric names contain a %20.

image

The metrics to plot looks like this:

image

Once I click on one of the sparklines, it does show data and also shows the metric names correctly.
image

I can't reproduce it on the demo. Not sure if there was maybe any change around the saved datatable parameters or so.

@tsteur tsteur added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jul 22, 2023
@sgiehl
Copy link
Member

sgiehl commented Jul 24, 2023

I'm able to reproduce that locally and on the demo as well. We run a encodeURIComponent on all rows before they are stored as data table params (See https://github.com/matomo-org/matomo/blob/5.x-dev/plugins/CoreVisualizations/javascripts/seriesPicker.js#L108). Guess that maybe isn't reverted before it's used.
Not sure if simply removing that encodeURIComponent might cause other implications.

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jul 24, 2023
@sgiehl sgiehl added this to the For Prioritization milestone Jul 24, 2023
@michalkleiner
Copy link
Contributor

Related to or a duplicate of #20635.

@tsteur
Copy link
Member Author

tsteur commented Jul 25, 2023

Isn't this a regression maybe? I'm pretty sure this used to work

@sgiehl
Copy link
Member

sgiehl commented Jul 28, 2023

Yes. This might be a regression of the migration to vue.js

@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jul 28, 2023
@sgiehl
Copy link
Member

sgiehl commented Aug 22, 2023

While checking this one again it turned out, that there actually also is another i18n related issue around evolution charts. If I e.g. configure that chart to show "Search Engines" and "Websites" and then change my language to German, the chart won't show any data was well. As for German there are no records "Search Engines" or "Websites". They are localized to "Suchmaschinen" and "Webseiten". So we might also need to think about storing the internal name and only showing the translation or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants