Upload & install plugin ZIP fails with "Wrong username and/or password."

[mattab]

In Matomo 5 RC, trying to upload a plugin ZIP of a plugin:

And entering the correct password,

then it fails with

An error occurred
Wrong username and/or password.

[sgiehl]

@mattab did you test that on Matomo 4 and does your password contain a char like & ?

[mattab]

@sgiehl reproduced on 5.0.0-rc2 so it's a regression I think?

[sgiehl]

Technically not a regression as the problem existed there before. The upload mechanism has it's own password check, which still uses Common::getRequestVar to receive the value. As it doesn't unsanitize the value, every char that might get escaped causes problems there. I'll prepare a PR to fix that, as it's easy to do.