Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evolution of "0%" shown since PHP 8.0 #21595

Closed
mneudert opened this issue Nov 24, 2023 · 0 comments · Fixed by #21781
Closed

Evolution of "0%" shown since PHP 8.0 #21595

mneudert opened this issue Nov 24, 2023 · 0 comments · Fixed by #21781
Assignees
@sgiehl
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Technical debt Issues the will help to reduce technical debt
Milestone
5.0.2

Comments

@mneudert
Copy link
Member

Back when PHP 8.0 was introduced the comparison of strings and numbers changed slightly.

One part hit by this change is the evolution percentage display, for example visible on the Visits Overview (0% example).

Previous to the PHP change, an evolution of "0%" was intentionally hidden, but since then became visible. A neutral evolution is properly styled so it most likely was never caught as a "change" or "error".

Before After

To clean up it should be decided whether the neutral evolution should be visible as of today, or should be hidden as the code once intended.
@mneudert mneudert added c: Design / UI For issues that impact Matomo's user interface or the design overall. To Triage An issue awaiting triage by a Matomo core team member Technical debt Issues the will help to reduce technical debt labels Nov 24, 2023
@sgiehl sgiehl added this to the For Prioritization milestone Nov 24, 2023
@sgiehl sgiehl removed the To Triage An issue awaiting triage by a Matomo core team member label Nov 24, 2023
@michalkleiner michalkleiner mentioned this issue Jan 1, 2024
Closed
4 tasks
@sgiehl sgiehl mentioned this issue Jan 8, 2024
Merged
11 tasks
@sgiehl sgiehl self-assigned this Jan 8, 2024
@sgiehl sgiehl modified the milestones: For Prioritization, 5.0.2 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Milestone
5.0.2
Development

Successfully merging a pull request may close this issue.

Always show zero evolution values for sparklines matomo-org/matomo
2 participants
@mneudert @sgiehl