Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use LFS when running UI tests #67

Closed
tsteur opened this issue Jan 11, 2021 · 3 comments
Closed

Always use LFS when running UI tests #67

tsteur opened this issue Jan 11, 2021 · 3 comments

Comments

@tsteur
Copy link
Member

tsteur commented Jan 11, 2021

Currently, when we are wanting to use LFS in a Matomo plugin which is in its own submodule/github repo then we need to do the following steps as documented in https://developer.matomo.org/guides/maintaining-plugins#how-do-i-fix-the-error-some-screenshots-are-not-stored-in-lfs to get travis to use LFS.

Ideally, this would not be needed and we'd simply always use LFS in the default travis already. This will simplify things for when we have new plugins.

Once we added it to the default travis yml then we should remove the documented part from the link above.

@sgiehl
Copy link
Member

sgiehl commented Jan 12, 2021

Guess the most "correct" solution would be to do this for all generated travis files:

{% if generationMode == 'core' %}
- . ./tests/travis/install_git_lfs.sh
{% endif %}

But that will require updating all travis.yml files

@tsteur
Copy link
Member Author

tsteur commented Jan 12, 2021

👍 I suppose we don't need to do it for now as we rarely add new plugins now but eventually it be great to do it when we maybe have some other change for travis yml that requires updating them

@sgiehl
Copy link
Member

sgiehl commented Jul 4, 2023

That should also work with the new github action tests

@sgiehl sgiehl closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants