Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XYDataImageAnnotation support #45

Closed
matoos32 opened this issue Nov 7, 2022 · 1 comment · Fixed by #76
Closed

Add XYDataImageAnnotation support #45

matoos32 opened this issue Nov 7, 2022 · 1 comment · Fixed by #76
Assignees
Labels
enhancement New feature or request

Comments

@matoos32
Copy link
Owner

matoos32 commented Nov 7, 2022

No description provided.

@matoos32 matoos32 added the enhancement New feature or request label Nov 7, 2022
@matoos32 matoos32 self-assigned this Nov 24, 2022
@matoos32
Copy link
Owner Author

matoos32 commented Nov 24, 2022

This one is hitting a road block and so time-gapless XYDataImageAnnotation is not going to be supported.

It's believed we need to somehow map the time domain width to a spanning discrete number of numeric indices emulating the width but the time domain width can be fractional in the discrete index domain. Instead of providing a best fit guess that could leave users wanting, I'm going to leave this capability unimplemented.

One could perhaps extend the XYDataImageBuilder class to override its mapXToTimeIndex() method and attempt writing their own.

Perhaps a convenience nearest neighbor implementatation could be written but I don't know what's suitable here. It might be best to use the new XYImageBuilder instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
1 participant