-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Minor typo in Mutiplication
section
#35
Comments
Yes, that should be Cartesian product is a bit more accurate (in that the result is the same dimensional), but not perfect in that the result is ordered (ex It is more of a raveled version of of the outer product. |
PR submitted. I see your point on "outer product" rather than "Cartesian product", eventhough |
closed via #36 |
thanks for fixing the documentation! |
You're welcome. |
I didn't find any function called
prod()
initertools
, so I assume thatitertools.prod()
in the documentation (section "Multiplication") refers in reality toitertools.product()
.Besides is "outer product" the correct name for this product? In
itertools.product()
docstring, the name "Cartesian product" is used and Wikipedia doesn't seem to give the exact same definition for the two products (see Cartesian vs outer).The text was updated successfully, but these errors were encountered: