Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Minor typo in Mutiplication section #35

Closed
afvincent opened this issue Jun 3, 2016 · 5 comments
Closed

DOC: Minor typo in Mutiplication section #35

afvincent opened this issue Jun 3, 2016 · 5 comments
Milestone

Comments

@afvincent
Copy link
Contributor

I didn't find any function called prod() in itertools, so I assume that itertools.prod() in the documentation (section "Multiplication") refers in reality to itertools.product().

Besides is "outer product" the correct name for this product? In itertools.product() docstring, the name "Cartesian product" is used and Wikipedia doesn't seem to give the exact same definition for the two products (see Cartesian vs outer).

@tacaswell
Copy link
Member

Yes, that should be itertools.product, can you put in a PR with that change?

Cartesian product is a bit more accurate (in that the result is the same dimensional), but not perfect in that the result is ordered (ex a[::-1]*b != a *b) where as sets are not.

It is more of a raveled version of of the outer product.

@afvincent
Copy link
Contributor Author

PR submitted.

I see your point on "outer product" rather than "Cartesian product", eventhough itertools.product is describded as "Cartesian product" in its own docstring, which forgets the fact it returns an ordered result (as it is also very common on the web to see questions and topics about the "Cartesian product of lists").

@WeatherGod
Copy link
Member

closed via #36

@WeatherGod
Copy link
Member

thanks for fixing the documentation!

@afvincent
Copy link
Contributor Author

You're welcome.

@QuLogic QuLogic modified the milestone: v1.0 Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants