Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-PNG extensions #48

Closed
jnothman opened this issue Mar 16, 2017 · 4 comments · Fixed by #194
Closed

Support non-PNG extensions #48

jnothman opened this issue Mar 16, 2017 · 4 comments · Fixed by #194

Comments

@jnothman
Copy link
Contributor

jnothman commented Mar 16, 2017

matplotlib's own image_comparison "decorator defaults to generating png, pdf and svg output, but in interest of keeping the size of the library from ballooning we should only include the svg or pdf outputs if the test is explicitly exercising a feature dependent on that backend." (from here).

Only supporting PNG seems very limiting, if not counter-intuitive.

@astrofrog
Copy link
Collaborator

+1 to supporting other formats - my only limitation in implementing this has been time. If you have time to contribute fixes for this, that would be great!

@tacaswell
Copy link
Member

I suspect much of the code for doing the other format -> png conversion so that these files can be compared can be directly copied from mpl.

@andrzejnovak
Copy link

Bump. Is anyone actively working on this? At least pdf?

@astrofrog
Copy link
Collaborator

I haven’t had a chance to work on this, and probably won’t be able to in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants