Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of having question mark (?) specified internally for each unknown block/item ID, this should be done automatically based on version property #40

Closed
Matriks404 opened this issue Jan 13, 2024 · 1 comment
Closed

Instead of having question mark (?) specified internally for each unknown block/item ID, this should be done automatically based on version property #40

Matriks404 opened this issue Jan 13, 2024 · 1 comment
Assignees
@Matriks404
Labels
Affects-Indev Affects Indev versions Affects-Infdev Affects Infdev versions Area-Blocks Blocks Area-Data Data (JSON files, etc.) Area-Items Item ID's Area-Quality Quality/Performance Is-Enhancement Enhancement request Priority-3 Low priority
Milestone
Codename Saxum (v...

Comments

@Matriks404
Copy link
Owner

Matriks404 commented Jan 13, 2024 •
edited
Loading

Each version with invalid item ID's has "hasUnknownItemIds": true property set up, so we should use it instead of manually adding ?'s in the ids.json file, which is pain.

Edit: I have figured out, that for early Infdev versions having property of having unknown item ID's set to true doesn't make much sense, since they are unlikely to be changed from late Indev at all, but this is still nice improvement, as this actually makes sense code-wise.
@Matriks404 Matriks404 added Area-Quality Quality/Performance Area-Data Data (JSON files, etc.) Area-Blocks Blocks Area-Items Item ID's Affects-Indev Affects Indev versions Affects-Infdev Affects Infdev versions Priority-3 Low priority Is-Enhancement Enhancement request labels Jan 13, 2024
@Matriks404 Matriks404 added this to the UrbanDasher-1 (v0.1) milestone Jan 13, 2024
@Matriks404 Matriks404 self-assigned this Jan 13, 2024
@Matriks404 Matriks404 pinned this issue Jan 14, 2024
@Matriks404
Copy link
Owner Author

Matriks404 commented Jan 15, 2024 •
edited
Loading

This was fixed in 71b9555.

Also similar behavior is added for handling unknown block ID's, even though no known version has these.

@Matriks404 Matriks404 unpinned this issue Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matriks404 Matriks404

Labels
Affects-Indev Affects Indev versions Affects-Infdev Affects Infdev versions Area-Blocks Blocks Area-Data Data (JSON files, etc.) Area-Items Item ID's Area-Quality Quality/Performance Is-Enhancement Enhancement request Priority-3 Low priority
Projects
None yet
Milestone
Codename Saxum (v1.0)
Development

No branches or pull requests
1 participant
@Matriks404