Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a plugin returns no output, don't update the menu. #762

Open
matryer opened this issue Aug 28, 2021 · 2 comments
Open

If a plugin returns no output, don't update the menu. #762

matryer opened this issue Aug 28, 2021 · 2 comments

Comments

@matryer
Copy link
Owner

matryer commented Aug 28, 2021

...However, it seems if the script produces no output it wipes out the menu portion which defeats my purpose. If you could somehow build a fix such that if the script sends no output that nothing is changed in the current display that would be great...

Originally posted by @mlcampbe in #738 (comment)

@matryer
Copy link
Owner Author

matryer commented Aug 28, 2021

@leaanthony Can you think of any reason not to do this? I doubt people are relying on this behaviour to have an empty plugin with empty space, are they?

@leaanthony
Copy link
Collaborator

Seems like a legit use case. Should be a case of checking the output and only calling update if it's not blank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants