Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half caster spell sheet #47

Closed
Tracked by #19
matsavage opened this issue Jan 11, 2024 · 11 comments · Fixed by #56
Closed
Tracked by #19

Half caster spell sheet #47

matsavage opened this issue Jan 11, 2024 · 11 comments · Fixed by #56

Comments

@matsavage
Copy link
Owner

matsavage commented Jan 11, 2024

Thanks very much very much for merging this!!!

I hope I can use this place also two questions -

  1. What would it take to adapt your template to a4paper?
  2. What would it take to adapt your spells list to fit, e.g., a cleric's spell list? I know dungeonsheets with the official dnd form uses a half caster's sheet for that.

Originally posted by @PJBrs in #45 (comment)

@matsavage
Copy link
Owner Author

@PJBrs I have created a branch on this issue and pushed the template to it:

%LaTeX with PSTricks extensions
%%Creator: Inkscape 1.0beta2 (2b71d25, 2019-12-03)
%%Please note this file requires PSTricks extensions
\psset{xunit=.5pt,yunit=.5pt,runit=.5pt}
\begin{pspicture}(816,1056)
{
\newrgbcolor{curcolor}{0.87058824 0.87058824 0.87058824}
\pscustom[linestyle=none,fillstyle=solid,fillcolor=curcolor]
{
\newpath

@matsavage
Copy link
Owner Author

@PJBrs I have completed the work on moving the template into separate files, would you be able to have a go at lining up the text boxes for the spells and colour switches for the proficiency markers.

Tip for the lining up is determine the position of the first box, then use the fixed offset to calculate the positions of the others.

@PJBrs
Copy link
Contributor

PJBrs commented Jan 14, 2024

Hmmm... The locations of the various boxes seems rather precise... Would there be any way to have that same precision, based on the original halfcaster sheet?

@PJBrs
Copy link
Contributor

PJBrs commented Jan 14, 2024

Nevermind, I think the numbers are pretty round --> PJBrs@b722948

@PJBrs
Copy link
Contributor

PJBrs commented Jan 14, 2024

Hmm... I think I did it :-)

But I didn't really test it fully... Hmm... Also, I don't know how to set prepared spells.

https://github.com/PJBrs/DND-5e-LaTeX-Character-Sheet-Template/tree/47-half-caster-spell-sheet

I can squash 'm together, if that helps!

P.S., Clearly something needs to change in dungeonsheets as well, and I didn't have all those spells for testing here.

P.P.S., So I don't know how to add the colour switches for the proficiency markers.

P.P.P.S., I just found out where the colour switches for the proficiency markers are.

P.P.P.P.S., I think I just added them, but they don't seem to render.

@matsavage
Copy link
Owner Author

All looking good, thanks for picking up, I am busy the next couple of weekends, so may end up being a while before I can do this myself.

To make the spell prepared colours render, you will have to update the colours of the fill for the circle next to the spell line, they can be found as in here:

\newrgbcolor{curcolor}{1 1 1}
\pscustom[linestyle=none,fillstyle=solid,fillcolor=curcolor]
{
\newpath
\moveto(47.20413482000001,504.07998739000004)
\curveto(49.28413477000001,504.07998739000004)(51.204134720000006,505.83998735)(51.204134720000006,507.9199873)
\curveto(51.204134720000006,510.15998723999996)(49.28413477000001,511.91998720000004)(47.20413482000001,511.91998720000004)
\curveto(44.96413488000001,511.91998720000004)(43.20413492000001,510.15998723999996)(43.20413492000001,507.9199873)
\curveto(43.20413492000001,505.83998735)(44.96413488000001,504.07998739000004)(47.20413482000001,504.07998739000004)
\closepath
}
}

I copy pasted these in the order they appeared from the template, so there is no 100% guarantee they are in order, but they should mostly be pretty close.

Coordinates for columns 2/3 should match in the vertical, but be different in the horizontal.

@PJBrs
Copy link
Contributor

PJBrs commented Jan 16, 2024

I think it's quite alright now! Needs more testing with a character with over 11 cantrips, over 26 level 1 spells, and over 19 spells for levels 3, 4, and 5 each.

To make this work with dungeonsheets, you need a small patch as follows (and maybe more, I just wanted to test):

diff --git a/dungeonsheets/latex.py b/dungeonsheets/latex.py
index 2db9423..20f1918 100644
--- a/dungeonsheets/latex.py
+++ b/dungeonsheets/latex.py
@@ -282,9 +282,10 @@ def msavage_spell_info(char):
                        'EighthLevelSpell',
                        'NinthLevelSpell']
     sheet_spaces = dict(zip(level_names,
-                    [8, 13, 13, 13, 13, 9, 9, 9, 7, 7]))
+                    [11, 26, 19, 19, 19, 19, 9, 9, 7, 7]))
     comp_letters = ["A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", 
-                  "L", "M"]
+                  "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V", 
+                  "W", "X", "Y", "Z"]
     spellList = char.spell_casting_info["list"]
     for k, v in spellList.items():
         slots_max = sheet_spaces[k]

And you need to change \renderspellsheet to \renderhalfspellsheet in dungeonsheets/forms/MSavage_template.tex.

Below picture is for my current character:
image

@PJBrs
Copy link
Contributor

PJBrs commented Jan 16, 2024

... Anyway, I'll do some more thorough testing when I get around it. Let me know if anything still is missing, if you want to turn this into a pull request, and if the commit messages need a bit more fleshing out. Or you can just grab these patches yourself, obviously.

In the meantime, suppose you had some time, it would be great if you'd test my dungeonsheets branch over here against your latest dndtemplate:

https://github.com/PJBrs/dungeon-sheets/tree/MSavage-latex-template

I'd like to see it have a little bit more testing before I open another pull request with dungeonsheets.

@matsavage
Copy link
Owner Author

matsavage commented Jan 16, 2024 via email

@PJBrs
Copy link
Contributor

PJBrs commented Jan 16, 2024

OK! In that case, it'd be great if you could test my https://github.com/PJBrs/dungeon-sheets/tree/MSavage-latex-template tree, and if you deem it successful, I'll raise that PR in dungeonsheets. I'll add the halfcastersheet PR over here after that, and then I'll figure out how to properly implement it over at dungeonsheets. Thanks!

@matsavage
Copy link
Owner Author

matsavage commented Jan 16, 2024 via email

@matsavage matsavage linked a pull request Jan 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants