Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show index.html for Lit components #138

Closed
justinfagnani opened this issue Jan 6, 2023 · 2 comments · Fixed by #140
Closed

Don't show index.html for Lit components #138

justinfagnani opened this issue Jan 6, 2023 · 2 comments · Fixed by #140

Comments

@justinfagnani
Copy link
Contributor

For Lit you show the index.html file for every example. Not only does it show up first, obscuring the actual example, but it makes the Lit examples look more complicated when you don't show index.html with <script> tags for the other frameworks, or any other usage site.

I think you should only show index.html when you also show usage examples in the other frameworks.

@matschik
Copy link
Owner

matschik commented Jan 7, 2023

While refactoring Component Party, I noticed that ! You are totally right !
It's not fair to Lit since the other frameworks does not have any "index.html". It was just interesting how a Lit component is rendered into the html file.

To address this, I just created #139 to show how each framework is rendered into the final "index.html".
I'll remove "index.html" from Lit examples.

@justinfagnani
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants