fix(button): fix bug similar to #377 (#382)

matsp · Aug 12, 2019 · 24d6a26 · 24d6a26
1 parent 13895fc
commit 24d6a26
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/components/button/Button.vue b/components/button/Button.vue
@@ -75,10 +75,10 @@ export default {
   },
   watch: {
     classes () {
-      this.reinitRipple()
+      this.reInstantiateRipple()
     },
     ripple () {
-      this.reinitRipple()
+      this.reInstantiateRipple()
     }
   },
   mounted () {
@@ -111,10 +111,17 @@ export default {
         })
       }
     },
-    reinitRipple () {
-      if (this.mdcRipple) {
-        this.mdcRipple.destroy()
-        if (this.ripple) this.mdcRipple = MDCRipple.attachTo(this.$el)
+    reInstantiateRipple () {
+      if (this.ripple) {
+        if (this.mdcRipple) {
+          this.mdcRipple.destroy()
+        }
+        MDCRipple.attachTo(this.$el)
+      } else {
+        if (this.mdcRipple) {
+          this.mdcRipple.destroy()
+        }
+        this.mdcRipple = undefined
       }
     }
   }