Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

Commit

Permalink
fix: Add disconnect before destroyment
Browse files Browse the repository at this point in the history
  • Loading branch information
matsp committed Apr 23, 2018
1 parent 36f83b1 commit 63ccb4a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions components/card/Card.vue
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ export default {
subtree: true
})
},
beforeDestroy () {
this.slotOberserver.disconnect()
},
methods: {
updateSlots () {
if (this.$slots.actionButtons) {
Expand Down
1 change: 1 addition & 0 deletions components/dialog/Dialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export default {
this.mdcDialog = MDCDialog.attachTo(this.$el)
},
beforeDestroy () {
this.slotOberserver.disconnect()
this.mdcDialog.destroy()
},
methods: {
Expand Down
1 change: 1 addition & 0 deletions components/fab/Fab.vue
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export default {
if (this.interactive) { this.mdcRipple = MDCRipple.attachTo(this.$el) }
},
beforeDestroy () {
this.slotOberserver.disconnect()
if (this.interactive) { this.mdcRipple.destroy() }
},
methods: {
Expand Down

0 comments on commit 63ccb4a

Please sign in to comment.