This repository has been archived by the owner on Nov 30, 2020. It is now read-only.
feat(fab): reimplementing FAB #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `extended` prop no longer in use BREAKING CHANGE: label and icon become separated component BREAKING CHANGE: icon slots no longer in use fix the bug that can not implement an extended FAB with Text label followed by icon make ripple optional add snapshots and update docs
|
@matsp Sorry to bother you but after some consideration, I think I made a mistake. It's better to add a slot I'll redo it and open a new PR soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
extendedprop no longer in useBREAKING CHANGE: label and icon become separated component
BREAKING CHANGE: icon slots no longer in use
fix the bug that can not implement an extended FAB with Text label followed by icon
make ripple optional
add snapshots and update docs