Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid's definition of "Previous sibling (layer)" seems backwards #26

Closed
lukeadamson opened this issue Nov 4, 2015 · 4 comments
Closed

Comments

@lukeadamson
Copy link

When you have a set of layers that looks like this in Sketch's layer panel:

  • Group 1
    • Layer B
    • Layer A

Fluid seems to think that "Layer B" is the previous sibling of "Layer A", but that's backwards. Sketch renders from bottom up, so first comes Layer A, then comes Layer B, which means that Layer A is the previous sibling of Layer B. It looks a little counterintuitive, but that's the real rendering order.

This matters quite a bit when the layers overlap. You can't simply change the order of layers in the layer tree to match Fluid's definition without affecting how they actually render (and probably occluding layers you wanted to be able to see).

@rorysmyth
Copy link

+1

@matt-curtis
Copy link
Owner

You're right, somehow I missed this, we'll correct it ASAP.

@pulpy
Copy link

pulpy commented Nov 16, 2015

So if this is the case, would it be possible to then have a Following Sibling constraint added? Because if you have a layer (say a header layer that has a transparent drop shadow. If following above diagram it would be layer B) to be in the Z axis space above, say a list of info rows and you want to constrain the list group ( I put them in a group so I will call it List group. Layer A in above diagram) to the Header layer Group but below it in Z axis so the header layer will appear top have a drop shadow on the list group? Make sense?

I love this plug in btw keep up the good work!, Can't stop using it on pretty much every layer. Do I need to do this, probably not, but I feel that repeated elements would stay more consistent though out the apps I design if I tweak sizes of elements here and there.

@matt-curtis
Copy link
Owner

@pulpy

So as I understand it, you've got:

  • Parent Group or Artboard
    • Layer B (Header)
    • Layer A (List Group)

And you want to constrain List Group to Header, right? I can see how a Next/Following Sibling option would be useful. At the time, though, the way Fluid resolves relativity and constraints doesn't make this possible...

However, I'll definitely consider it. Create a separate issue for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants