Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type unification between C types and non-C types #79

Closed
simonlindholm opened this issue Apr 28, 2020 · 0 comments · Fixed by #94
Closed

Support type unification between C types and non-C types #79

simonlindholm opened this issue Apr 28, 2020 · 0 comments · Fixed by #94

Comments

@simonlindholm
Copy link
Collaborator

            elif not isinstance(x.ptr_to, Type) and not isinstance(y.ptr_to, Type):
                # TODO: deep resolve_typedefs (needs a typemap)
                if not equal_types(x.ptr_to, y.ptr_to):
                    return False
            else:
                # TODO: unify Type and CType (needs a typemap)
                return False

We need some additional context for this; maybe store typemap in Type or CType? Or use some "thread local state"-like pattern, since we have only a single typemap that we should use anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant