Change -cgImage to -cgImageCopy to appease the Clang Static Analyzer.

mattball · Nov 23, 2009 · 083842e · 083842e
1 parent f10bd66
commit 083842e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/MBCoverFlowView.m b/MBCoverFlowView.m
@@ -769,7 +769,7 @@ - (void)_loadImageForLayer:(CALayer *)layer
 			imageRef = CGImageRetain(_placeholderRef);
 			[layer setValue:[NSNumber numberWithBool:NO] forKey:@"hasImage"];
 		} else {
-			imageRef = [image imageRef];
+			imageRef = [image imageRefCopy];
 			[layer setValue:[NSNumber numberWithBool:YES] forKey:@"hasImage"];
 		}
 
@@ -852,7 +852,7 @@ - (void)_recachePlaceholder
 
 	[placeholder unlockFocus];
 
-	_placeholderRef = [placeholder imageRef];
+	_placeholderRef = [placeholder imageRefCopy];
 
 	// Update the placeholder for all necessary items
 	for (CALayer *layer in [_scrollLayer sublayers]) {

diff --git a/NSImage+MBCoverFlowAdditions.h b/NSImage+MBCoverFlowAdditions.h
@@ -38,6 +38,6 @@
  *
  * @return      A CGImageRef representation for the image.
  */
-- (CGImageRef)imageRef;
+- (CGImageRef)imageRefCopy;
 
 @end
diff --git a/NSImage+MBCoverFlowAdditions.m b/NSImage+MBCoverFlowAdditions.m
@@ -29,7 +29,7 @@ of this software and associated documentation files (the "Software"), to deal
 
 @implementation NSImage (MBCoverFlowAdditions)
 
-- (CGImageRef)imageRef
+- (CGImageRef)imageRefCopy
 {
 	CGContextRef context = CGBitmapContextCreate(NULL/*data - pass NULL to let CG allocate the memory*/, 
 												   [self size].width,