npm audit fix & add option to enable extension for ALL languages #14
Conversation
Signed-off-by: Kipras Melnikovas <sarpixo@gmail.com>
Signed-off-by: Kipras Melnikovas <sarpixo@gmail.com>
Signed-off-by: Kipras Melnikovas <sarpixo@gmail.com>
Signed-off-by: Kipras Melnikovas <sarpixo@gmail.com>
Signed-off-by: Kipras Melnikovas <sarpixo@gmail.com>
|
To get completions workings, you also need to update the completion provider registration: vscode-emojisense/src/extension.ts Line 12 in afc8ce6 I think you can pass |
package.json
Outdated
| "emojisense.enableEmojisInAllLanguages": { | ||
| "type": "boolean", | ||
| "description": "Lets you easily enable emoji decorators in ALL languages", | ||
| "default": true |
There was a problem hiding this comment.
Default this to false instead. Emoji suggestions will get in the way in many languages
There was a problem hiding this comment.
Should I also default the enableEmojisInAllLanguages to false in Configuration @ src/configuration.ts?
There was a problem hiding this comment.
Yes, when you install the extension the default should be false. enableEmojisInAllLanguages should be an opt-in setting.
On further thought, a cleaner way to express this may be to support using * with the emojisense.languages setting. That way you can enable or disable completions and decorators separately and we don't need another setting:
"emojisense.languages": {
"*": true
}or
"plaintext": {
"markupCompletionsEnabled": false,
"emojiDecoratorsEnabled": true
}
}There was a problem hiding this comment.
I definitely agree - I've thought about having the star thingie * too, but am kinda new to extension development and it didn't seem to work with either of my approaches. I'm currently busy and won't be able to take care of this, so anyone's free to fork my fork and go from there.
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
|
Hey, saw you pushed a commit. Just checking in to see what you want to do with this PR? I think it is headed in the correct direction but needs a few changes |
|
Closing this as out of date |
Hello,
the feature of being able to just enable this extension for ALL languages would be very useful.
If I did everything correctly, this would fix #10.
Also, if this were to be accepted - the docs would need an update too about the extra option.
Please provide additional information if there's anything I missed - I'm new to vscode's extension development.
Edit:
This works on say .txt files, but it doesn't somehow in .js and many other files (the extension doesn't give you intellisense with available emojis; it gives the emoji only when you fully type it out but doesn't delete the :foo: code). Additional fixes are needed @mattbierner