Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor state system #53

Closed
mattdelsordo opened this issue Sep 20, 2018 · 0 comments
Closed

Refactor state system #53

mattdelsordo opened this issue Sep 20, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@mattdelsordo
Copy link
Owner

mattdelsordo commented Sep 20, 2018 •
edited

The state system architecture has two issues that could be addressed:

  1. Each state is more or less a modified copy-paste of Idle. I originally envisioned all the states being pretty distinct but it ended up easier to just make them all based off the original one, and at this point the basic animation framework needs to be factored out because it repeats itself a LOT.
  2. The total amount of frames in an animation is currently just a magic number. It equals 4 in all animations EXCEPT the food one, I think.
@mattdelsordo mattdelsordo added the bug Something isn't working label Sep 20, 2018
@mattdelsordo mattdelsordo changed the title Un-magic-number-ify state animation frame count Refactor state system Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattdelsordo