Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timezone a configurable setting #4

Open
mattdy opened this issue Nov 29, 2015 · 1 comment
Open

Make timezone a configurable setting #4

mattdy opened this issue Nov 29, 2015 · 1 comment

Comments

@mattdy
Copy link
Owner

mattdy commented Nov 29, 2015

There are several instances where Europe/London is hard-coded as the timezone to use in configuring alarms etc. It would be nicer to make this configurable in some manner, most likely through Settings.

However - the implications of putting an invalid timezone in here (ie: one not on this list) could be quite severe, so some kind of validation may be required before falling back to a sensible default?

@jwr456
Copy link

jwr456 commented Nov 29, 2015

Matt, check my code. I did this by allowing the timezone to be picked from a select html form which is populated by Python timezones programmatically.

Sent from my iPhone 6S

On Nov 29, 2015, at 5:25 AM, Matt Dyson notifications@github.com wrote:

There are several instances where Europe/London is hard-coded as the timezone to use in configuring alarms etc. It would be nicer to make this configurable in some manner, most likely through Settings.

However - the implications of putting an invalid timezone in here (ie: one not on this list) could be quite severe, so some kind of validation may be required before falling back to a sensible default?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants