Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class editing when 'focus-within' keyboard is contained #35

Closed
matteobad opened this issue Jul 29, 2019 · 1 comment · Fixed by #44
Closed

Class editing when 'focus-within' keyboard is contained #35

matteobad opened this issue Jul 29, 2019 · 1 comment · Fixed by #44
Assignees
@matteobad
Labels
bug Something isn't working released

Comments

@matteobad
Copy link
Owner

Describe the bug
The method used to remove a class using the setAttribute breaks all class names that contains the 'focus-within' string in them. For example 'js-focus-within' beacames 'js-' when focus is lost

To Reproduce
Steps to reproduce the behavior:

  1. Go to any page
  2. Lose focus
  3. See the class on the body element

Expected behavior
Only the exact class name should be affected

Desktop (please complete the following information):

  • OS: Windows
  • Browser IE
  • Version 11
@matteobad matteobad self-assigned this Jul 29, 2019
@matteobad matteobad added the bug Something isn't working label Jul 29, 2019
@AndrewLeedham AndrewLeedham mentioned this issue Oct 29, 2019
Merged
@matteobad
Copy link
Owner Author

🎉 This issue has been resolved in version 5.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matteobad matteobad

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
1 participant
@matteobad