Event filters by Param not working

[bitcoinwarrior1]

https://github.com/BANKEX/web3swift/issues/316 & https://stackoverflow.com/questions/60665023/web3swift-event-filtering-via-params-not-working

[hakumai-iida]

It looks like that EventFilter does not work, if the count of "parameterFilters" is 1.
Please fix the codes like below.

/Sources/web3swift/Contract/EventFiltering.swift

// change [0] to [-1]
line 77: var lastNonemptyFilter = -1/* 0 */

// change [!=] to [>=]
line 84: if lastNonemptyFilter >= /* != */ 0 {

Best regards,

[hakumai-iida]

Also EventFilter does not work, if events have jumping indexed parameters like below.

  event JumpingIndexed( uint val1,
                        uint indexed indexedVal2,  // topics[1]
                        uint val3,
                        uint indexed indexedVal4,  // topics[2]
                        address indexed from       // topics[3]
                      );

Please replace the codes

/Sources/web3swift/Contract/EventFiltering.swift

88:             let input = event!.inputs[i]
89:             if filterValues != nil && !input.indexed {return nil}

with below ones

                // check target "indexed" parameter existing, if filterValues is valid
                if filterValues != nil {
                    var isFound = false
                    var targetIndexedPosition = i
                    for j in 0 ..< event!.inputs.count{
                        if event!.inputs[j].indexed {
                            if targetIndexedPosition == 0 {
                                isFound = true
                                break
                            }
                            targetIndexedPosition -= 1
                        }
                    }
                    
                    if !isFound {return nil}
                }

Best regards,

[bitcoinwarrior1]

Thanks mate, did you want to submit a PR to the authors? I can but you should get the contributor kudos :)

[skywinder]

Thanks!
Please, make an PR.
I would be glad to support your contribution via our gitcoin grant as well! 👍

[hakumai-iida]

I am glad that your problem was solved.

And I do not have any permision to push a sub-branch for a pull request.
If I can get a permision, I will make a pull request.

Or please make a pull request instead of me, if you can and it's not too much trouble.

Best reagrds,

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 12.0 DAI (12.0 USD @ $1.0/DAI) attached to it as part of the skywinder fund.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $61,824.51 more funded OSS Work available on the Gitcoin Issue Explorer

[skywinder]

Everyone can make a pull request. Please, kindly check settings, first you need to for repository. Then push branch to your fork. Then you can make a pull request via website

[hakumai-iida]

Thank you very much, I will check the setting, and try.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 266 years, 8 months from now.
Please review their action plans below:

1) hakumai-iida has been approved to start work.

Fixed below.

• EventFiltering does not work, if the count of "parameterFilters" is 1.
• Also does not work, if events have jumping indexed parameters.

(This is my first time using gitcoin, is that OK?)

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 12.0 DAI (12.0 USD @ $1.0/DAI) has been submitted by:

1. @hakumai-iida

@skywinder please take a look at the submitted work:

• (Link Not Provided) by @hakumai-iida

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $74,283.53 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

The funding of 12.0 DAI (12.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @hakumai-iida.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $78,316.66 more funded OSS Work available on the Gitcoin Issue Explorer