Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation check Forge version to ensure It's foundry-zksync Forge #137

Open
dutterbutter opened this issue May 14, 2024 · 0 comments
Open

Comments

@dutterbutter
Copy link
Contributor

Description

Currently, the script checks for the installation of Forge using the command forge --version. However, it does not verify if the installed Forge is from the foundry-zksync repository. This can lead to issues if a different version of Forge is installed.

Suggested Solution

Add a check to ensure that the installed Forge is from the foundry-zksync repository. This can be done by verifying the version or source of the installation.

Code Reference

const isInstalled = await executeCommand("forge --version", { silent: true });
if (!isInstalled) {
  spinner.fail(
    "Forge is not installed from the `foundry-zksync` repository. Please visit the official installation guide at https://github.com/matter-labs/foundry-zksync and follow the instructions to install it. Once installed, try running the command again."
  );
  return;
}

Additional Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant