Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): File-info tool to help prover debugging #1216

Merged
merged 8 commits into from Mar 18, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Feb 22, 2024

What ❔

  • a helper tool to see the contents of the prover files - it auto-guesses the file type and displays information.

Why ❔

  • to make prover debugging easier
cargo run --release  file-info 1_0_1_Scheduler_0.bin

image

@mm-zk mm-zk changed the title WIP: prover tools feat(prover): File-info tool to help prover debugging Feb 23, 2024
@mm-zk mm-zk requested a review from EmilLuta February 23, 2024 16:52
@mm-zk mm-zk marked this pull request as ready for review February 23, 2024 16:52
@EmilLuta
Copy link
Contributor

EmilLuta commented Mar 4, 2024

Let's address lints and what not. This will have to live somewhere else, but for now it's a good place so we don't lose the work. This will be refactored and added to new prover tooling either by me, or by @Deniallugo, if he gets there faster.

@mm-zk
Copy link
Collaborator Author

mm-zk commented Mar 6, 2024

PTAL @EmilLuta

EmilLuta
EmilLuta previously approved these changes Mar 6, 2024
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this belongs in current format here. @Deniallugo is this something that you would integrate in zk CLI?

@Deniallugo
Copy link
Contributor

I think we can keep it here for some time and i'll migrate it later

@EmilLuta EmilLuta added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 9759907 Mar 18, 2024
24 checks passed
@EmilLuta EmilLuta deleted the mmzk0222_prover_tools branch March 18, 2024 20:33
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[12.2.0](prover-v12.1.0...prover-v12.2.0)
(2024-03-28)


### Features

* **api:** introduce mempool cache
([#1460](#1460))
([c5d6c4b](c5d6c4b))
* **commitment-generator:** `events_queue` shadow mode
([#1138](#1138))
([9bb47fa](9bb47fa))
* Drop prover tables in core database
([#1436](#1436))
([0d78122](0d78122))
* Follow-up for DAL split
([#1464](#1464))
([c072288](c072288))
* **prover:** export prover traces through OTLP
([#1427](#1427))
([16dce75](16dce75))
* **prover:** File-info tool to help prover debugging
([#1216](#1216))
([9759907](9759907))
* Separate Prover and Server DAL
([#1334](#1334))
([103a56b](103a56b))
* support running consensus from snapshot (BFT-418)
([#1429](#1429))
([f9f4d38](f9f4d38))


### Bug Fixes

* **api:** Fix API server shutdown flow
([#1425](#1425))
([780f6b0](780f6b0))
* **prover:** Remove FriProtocolVersionId
([#1510](#1510))
([6aa51b0](6aa51b0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Roman Brodetski <rb@matterlabs.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants