feat: Split witness generator timeout configs by round #1505
Conversation
There was a problem hiding this comment.
This does the job. In the future, we may consider splitting this in multiple configs.
Question: How do you want to roll this out? The way I'd do it -- keep the old config variable and use it as a default and have all the others as optionals. This would allow us to rollout, without breaking anything due to missing configs. And also allows us to set a general value for all envs (although we may want to remove it in the future). How do you envision it?
|
Initially I was thinking about simply adding new values to configs along with the previous one - then after deploying this one we can simply remove old value. But your option is also good, I don't have a strong opinion on that. UPD: your option might be better because we might forget to remove old values + I like an idea of having a default value |
|
I think our configs are strongly related to one another. I'd verify locally what happens if we go with the plan you proposed. I know someone who caused a 15 minutes outage going this route. If we gradually roll this out, should be fine. |
What I personally don't like about this -- we may as well forget to set the specifics. I'll let you decide on the final call. |
… afo/revisit-prover-configs
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
🤖 I have created a release *beep* *boop* --- ## [22.1.0](core-v22.0.0...core-v22.1.0) (2024-03-28) ### Features * Drop prover tables in core database ([#1436](#1436)) ([0d78122](0d78122)) * **en:** consistency checker persistent cursor ([#1466](#1466)) ([03496e6](03496e6)) * **en:** Make snapshot syncing future-proof ([#1441](#1441)) ([8c26a7a](8c26a7a)) * **genesis:** Using genesis config only during the genesis ([#1423](#1423)) ([4b634fd](4b634fd)) * **node_framework:** Add a task to handle sigint ([#1471](#1471)) ([2ba6527](2ba6527)) * **node-framework:** Add circuit breaker checker layer to framework ([#1452](#1452)) ([2c7a6bf](2c7a6bf)) * **prover:** export prover traces through OTLP ([#1427](#1427)) ([16dce75](16dce75)) * sigint initialization only after snapshots is applied ([#1356](#1356)) ([c7c7356](c7c7356)) * Split witness generator timeout configs by round ([#1505](#1505)) ([8074d01](8074d01)) * **state-keeper:** implement asynchronous RocksDB cache ([#1256](#1256)) ([da41f63](da41f63)) * **state-keeper:** Refactor persistence in `StateKeeper` ([#1411](#1411)) ([e26091a](e26091a)) * **state-keeper:** Remove `WitnessBlockState` generation from state keeper ([#1507](#1507)) ([8ae0355](8ae0355)) * Switch contract verification API to axum and get rid of actix-web usage ([#1467](#1467)) ([e7a9d61](e7a9d61)) ### Bug Fixes * **api:** `filters_disabled` should only affect HTTP endpoints ([#1493](#1493)) ([8720568](8720568)) * **api:** Fix API server shutdown flow ([#1425](#1425)) ([780f6b0](780f6b0)) * **prover:** Remove FriProtocolVersionId ([#1510](#1510)) ([6aa51b0](6aa51b0)) * **prover:** Remove redundant LoadingMode ([#1496](#1496)) ([e7583f4](e7583f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
## What ❔ Have different values in configs for witness generation timeouts by round ## Why ❔ To be able to set custom timeouts by round(sometimes times of generation differs for different rounds) ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`. (cherry picked from commit 8074d01)
What ❔
Have different values in configs for witness generation timeouts by round
Why ❔
To be able to set custom timeouts by round(sometimes times of generation differs for different rounds)
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.