Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adds a get proof endpoint in zks namespace to http endpoint on main node #504

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

montekki
Copy link
Member

What ❔

Support for zks_getProof was accedentally only implemented for WS apis in #455, this PR deploys them also to HTTP endpoints.

@montekki montekki requested a review from a team as a code owner November 16, 2023 12:32
@montekki montekki requested a review from slowli November 16, 2023 12:33
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Akchually 🤓, the PR title isn't technically true: we use the jsonrpc backend both for HTTP and WS API servers for the external node; jsonrpsee is only used for HTTP on the main node.

core/lib/web3_decl/src/namespaces/zks.rs Outdated Show resolved Hide resolved
@montekki montekki changed the title feat(core): adds a get proof endpoint in zks namespace to http endpoint feat(core): adds a get proof endpoint in zks namespace to http endpoint on main node Nov 16, 2023
@montekki montekki added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 0ac4a4d Nov 16, 2023
22 checks passed
@montekki montekki deleted the fvs-add-getproof-to-http-servers branch November 16, 2023 14:44
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2023
🤖 I have created a release *beep* *boop*
---


##
[18.1.0](core-v18.0.3...core-v18.1.0)
(2023-11-20)


### Features

* added consensus types and consensus column to miniblocks table
([#490](#490))
([f9ae0ad](f9ae0ad))
* Adds `prover_group_id` label into `fri_prover_prover_job` metric
([#503](#503))
([851e800](851e800))
* **core:** adds a get proof endpoint in zks namespace to http endpoint
on main node
([#504](#504))
([0ac4a4d](0ac4a4d))
* **merkle tree:** Allow random-order tree recovery
([#485](#485))
([146e4cf](146e4cf))


### Bug Fixes

* **core:** add tree url to jsonrpsee server on main node
([#512](#512))
([7c137b7](7c137b7))
* Fixes panic on unknown FRI prover group id
([#522](#522))
([1c315f3](1c315f3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants