Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(external-node): Check txs at insert time instead of read time #555

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(external-node): Check txs at insert time instead of read time #555

merged 1 commit into from
Nov 28, 2023

Conversation

EmilLuta
Copy link
Contributor

ENs are broken due to tx mismatch. This PR will allow ENs to restart and hopefully update the state. More information here.

This was discussed with @danil.

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@EmilLuta
hotfix(external-node): Check txs at insert time instead of read time
9f1427b 
ENs are broken due to tx mismatch. This PR will allow ENs to restart and
hopefully update the state. More information [here](https://www.notion.so/matterlabs/EN-is-broken-on-testnet-due-to-mismatched-txs-11c68bca2a4047cb8730e21e21f4ac41).

This was discussed with @danil.
@EmilLuta EmilLuta requested a review from a team as a code owner November 28, 2023 16:51
@EmilLuta EmilLuta changed the title hotfix(external-node): Check txs at insert time instead of read time fix(external-node): Check txs at insert time instead of read time Nov 28, 2023
@otani88 otani88 merged commit 9ea02a1 into main Nov 28, 2023
21 of 23 checks passed
@otani88 otani88 deleted the evl-hotfix-en-for-broken-tx branch November 28, 2023 17:05
@zksync-era-bot zksync-era-bot mentioned this pull request Nov 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2023
@zksync-era-bot
chore(main): release core 18.3.1 (#558)
bd60f1c 
🤖 I have created a release *beep* *boop*
---


##
[18.3.1](core-v18.3.0...core-v18.3.1)
(2023-11-28)


### Bug Fixes

* **external-node:** Check txs at insert time instead of read time
([#555](#555))
([9ea02a1](9ea02a1))
* Update comments post-hotfix
([#556](#556))
([339e450](339e450))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EmilLuta @Deniallugo @otani88