Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: applied status snapshots dal #679

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Conversation

tomg10
Copy link
Contributor

@tomg10 tomg10 commented Dec 13, 2023

Adding applied snapshots DAL that will be used to track status of EN node applied snapshot.

@tomg10 tomg10 requested a review from slowli December 13, 2023 13:46
@tomg10 tomg10 requested a review from slowli December 18, 2023 19:20
@tomg10 tomg10 force-pushed the applied-snapshots-status-dal branch from 1ee7377 to 0c6ae28 Compare December 18, 2023 19:20
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some relatively minor nits; overall, looks solid 👍

core/lib/dal/src/applied_snapshot_status_dal.rs Outdated Show resolved Hide resolved
core/lib/dal/src/applied_snapshot_status_dal.rs Outdated Show resolved Hide resolved
core/lib/types/src/snapshots.rs Outdated Show resolved Hide resolved
core/lib/types/src/snapshots.rs Outdated Show resolved Hide resolved
@tomg10 tomg10 force-pushed the applied-snapshots-status-dal branch from a500ed4 to beb055b Compare December 20, 2023 13:13
@tomg10 tomg10 requested a review from slowli December 20, 2023 16:22
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@tomg10 tomg10 added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit 2e9f23b Dec 21, 2023
24 checks passed
@tomg10 tomg10 deleted the applied-snapshots-status-dal branch December 21, 2023 17:04
RomanBrodetski pushed a commit that referenced this pull request Dec 25, 2023
🤖 I have created a release *beep* *boop*
---


##
[18.10.0](core-v18.9.0...core-v18.10.0)
(2023-12-25)


### Features

* **api:** Add metrics for `jsonrpsee` subscriptions
([#733](#733))
([39fd71c](39fd71c))
* **api:** remove jsonrpc backend
([#693](#693))
([b3f0417](b3f0417))
* applied status snapshots dal
([#679](#679))
([2e9f23b](2e9f23b))
* **en:** Make reorg detector work with pruned data
([#712](#712))
([c4185d5](c4185d5))
* Remove data fetchers
([#694](#694))
([f48d677](f48d677))
* Remove zks_getConfirmedTokens method
([#719](#719))
([9298b1b](9298b1b))


### Bug Fixes

* added waiting for prometheus to finish
([#745](#745))
([eed330d](eed330d))
* **EN:** temporary produce a warning on pubdata mismatch with L1
([#758](#758))
([0a7a4da](0a7a4da))
* **prover:** Add logging for prover + WVGs
([#723](#723))
([d7ce14c](d7ce14c))
* remove leftovers after
[#693](#693)
([#720](#720))
([e93aa35](e93aa35))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants