feat(api): remove jsonrpc backend #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montekki
changed the title
…-subscriptions-using-jsonrpsee
montekki
commented
Dec 15, 2023
montekki
commented
Dec 15, 2023
slowli
reviewed
Dec 18, 2023
core/lib/zksync_core/src/api_server/web3/backend_jsonrpsee/batch_limiter_middleware.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/api_server/web3/backend_jsonrpsee/batch_limiter_middleware.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/api_server/web3/backend_jsonrpsee/batch_limiter_middleware.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/api_server/web3/backend_jsonrpsee/batch_limiter_middleware.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/api_server/web3/backend_jsonrpsee/batch_limiter_middleware.rs
Show resolved
Hide resolved
slowli
reviewed
Dec 19, 2023
@montekki people start to hack around the code too (and will do that more with zkStack), so we should start to treat the API our code provides too; I'd propose it to be a |
montekki
changed the title
slowli
previously approved these changes
Dec 20, 2023
montekki
deleted the
fvs-pla-673-implement-subscriptions-using-jsonrpsee
branch
This was referenced Dec 20, 2023
montekki
added a commit
that referenced
this pull request
Dec 21, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
## What ❔ Removes leftover files. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `cargo spellcheck --cfg=./spellcheck/era.cfg --code 1`.
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
## What ❔ A small follow-up PR for #693 that introduces some metrics allowing to track the health of the new approach. Also, does minor refactoring for the API server builder so it's more typesafe. ## Why ❔ Observability and maintainability. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `cargo spellcheck --cfg=./spellcheck/era.cfg --code 1`.
RomanBrodetski
pushed a commit
that referenced
this pull request
Dec 25, 2023
🤖 I have created a release *beep* *boop* --- ## [18.10.0](core-v18.9.0...core-v18.10.0) (2023-12-25) ### Features * **api:** Add metrics for `jsonrpsee` subscriptions ([#733](#733)) ([39fd71c](39fd71c)) * **api:** remove jsonrpc backend ([#693](#693)) ([b3f0417](b3f0417)) * applied status snapshots dal ([#679](#679)) ([2e9f23b](2e9f23b)) * **en:** Make reorg detector work with pruned data ([#712](#712)) ([c4185d5](c4185d5)) * Remove data fetchers ([#694](#694)) ([f48d677](f48d677)) * Remove zks_getConfirmedTokens method ([#719](#719)) ([9298b1b](9298b1b)) ### Bug Fixes * added waiting for prometheus to finish ([#745](#745)) ([eed330d](eed330d)) * **EN:** temporary produce a warning on pubdata mismatch with L1 ([#758](#758)) ([0a7a4da](0a7a4da)) * **prover:** Add logging for prover + WVGs ([#723](#723)) ([d7ce14c](d7ce14c)) * remove leftovers after [#693](#693) ([#720](#720)) ([e93aa35](e93aa35)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
The new release of
jsonrpseeremoves all known blockers for removingjsonrpcbackend.Checklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.