feat: Remove zks_getConfirmedTokens method #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
approved these changes
Dec 21, 2023
RomanBrodetski
pushed a commit
that referenced
this pull request
Dec 25, 2023
🤖 I have created a release *beep* *boop* --- ## [18.10.0](core-v18.9.0...core-v18.10.0) (2023-12-25) ### Features * **api:** Add metrics for `jsonrpsee` subscriptions ([#733](#733)) ([39fd71c](39fd71c)) * **api:** remove jsonrpc backend ([#693](#693)) ([b3f0417](b3f0417)) * applied status snapshots dal ([#679](#679)) ([2e9f23b](2e9f23b)) * **en:** Make reorg detector work with pruned data ([#712](#712)) ([c4185d5](c4185d5)) * Remove data fetchers ([#694](#694)) ([f48d677](f48d677)) * Remove zks_getConfirmedTokens method ([#719](#719)) ([9298b1b](9298b1b)) ### Bug Fixes * added waiting for prometheus to finish ([#745](#745)) ([eed330d](eed330d)) * **EN:** temporary produce a warning on pubdata mismatch with L1 ([#758](#758)) ([0a7a4da](0a7a4da)) * **prover:** Add logging for prover + WVGs ([#723](#723)) ([d7ce14c](d7ce14c)) * remove leftovers after [#693](#693) ([#720](#720)) ([e93aa35](e93aa35)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
RomanBrodetski
added a commit
that referenced
this pull request
Dec 25, 2023
This reverts commit 9298b1b.
RomanBrodetski
added a commit
that referenced
this pull request
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Removes the
zks_getConfirmedTokensmethod.Why ❔
This method was internal only and is no longer needed.
The change isn't considered to be breaking, as this method has no measured usage on mainnet.
Checklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.