Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect exposing of log indexes #896

Merged
merged 3 commits into from
Jan 18, 2024
Merged

fix: Incorrect exposing of log indexes #896

merged 3 commits into from
Jan 18, 2024

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented Jan 18, 2024 •
edited

What ❔

Make log indexes in transaction exposed correctly

Why ❔

To behave correctly

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@Artemka374 Artemka374 changed the title fix: Incorrect exposing of lod indexes fix: Incorrect exposing of log indexes Jan 18, 2024
@Artemka374 Artemka374 added this pull request to the merge queue Jan 18, 2024
@Artemka374 Artemka374 removed this pull request from the merge queue due to a manual request Jan 18, 2024
@Artemka374 Artemka374 added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 12974fc Jan 18, 2024
27 checks passed
@Artemka374 Artemka374 deleted the fix/wrong-log-indexes-in-transactions branch January 18, 2024 14:53
@zksync-era-bot zksync-era-bot mentioned this pull request Jan 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 19, 2024
@zksync-era-bot
chore(main): release core 20.0.0 (#899)
dec608d 
🤖 I have created a release *beep* *boop*
---


##
[20.0.0](core-v19.2.0...core-v20.0.0)
(2024-01-19)


### ⚠ BREAKING CHANGES

* **vm:** fee model updates + 1.4.1
([#791](#791))

### Features

* **api:** Consider State keeper fee model input in the API
([#901](#901))
([3211687](3211687))
* **api:** Make Web3 API server work with pruned data
([#838](#838))
([0b7cd0b](0b7cd0b))
* **vm:** fee model updates + 1.4.1
([#791](#791))
([3564aff](3564aff))


### Bug Fixes

* addresses broken links in preparation for ci link check
([#869](#869))
([a78d03c](a78d03c))
* Incorrect exposing of log indexes
([#896](#896))
([12974fc](12974fc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo approved these changes

@slowli slowli Awaiting requested review from slowli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Artemka374 @Deniallugo