Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove zkevm_test_harness public reexport from zksync_types #929

Merged
merged 1 commit into from
Jan 24, 2024
Merged

feat: Remove zkevm_test_harness public reexport from zksync_types #929

merged 1 commit into from
Jan 24, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Jan 24, 2024

What ❔

  • Removes a public reexport of whole zkevm_test_harness from zksync_types.
  • Removes some code that turned out to be dead from object_store crate.

Why ❔

  • Reduces the surface of public APIs exposed by zksync_types crate.
  • Prerequisite for further separation of crypto stuff from zksync_types.
  • Dead code bad.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

mm-zk
mm-zk previously approved these changes Jan 24, 2024
View reviewed changes
core/bin/system-constants-generator/src/main.rs Show resolved Hide resolved
core/lib/object_store/src/objects.rs Outdated Show resolved Hide resolved
@popzxc popzxc force-pushed the popzxc-remove-public-test-harness-reexport branch from c9e4861 to c153eb9 Compare January 24, 2024 08:25
@popzxc popzxc marked this pull request as ready for review January 24, 2024 08:42
@popzxc popzxc requested review from EmilLuta and mm-zk January 24, 2024 08:42
@popzxc popzxc enabled auto-merge January 24, 2024 08:51
@popzxc popzxc added this pull request to the merge queue Jan 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 24, 2024
@popzxc popzxc added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit dd1a35e Jan 24, 2024
35 checks passed
@popzxc popzxc deleted the popzxc-remove-public-test-harness-reexport branch January 24, 2024 09:50
This was referenced Jan 24, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 29, 2024
@zksync-era-bot
chore(main): release prover 11.0.0 (#824)
8f55cae 
🤖 I have created a release *beep* *boop*
---


##
[11.0.0](prover-v10.1.0...prover-v11.0.0)
(2024-01-29)


### ⚠ BREAKING CHANGES

* **vm:** fee model updates + 1.4.1
([#791](#791))

### Features

* **api:** Make Web3 API server work with pruned data
([#838](#838))
([0b7cd0b](0b7cd0b))
* consensus component config for main node and external node
([#881](#881))
([1aed8de](1aed8de))
* **en:** Restore state keeper storage from snapshot
([#885](#885))
([a9553b5](a9553b5))
* fee model updates + 1.4.1 stage upgrade
([#897](#897))
([fa48c13](fa48c13))
* protobuf-generated json configs for the main node (BFT-371)
([#458](#458))
([f938314](f938314))
* Remove zkevm_test_harness public reexport from zksync_types
([#929](#929))
([dd1a35e](dd1a35e))
* **state-keeper:** circuits seal criterion
([#729](#729))
([c4a86bb](c4a86bb))
* **vm:** fee model updates + 1.4.1
([#791](#791))
([3564aff](3564aff))


### Bug Fixes

* address issue with spellchecker not checking against prover workspace
([#855](#855))
([4f55926](4f55926))
* addresses broken links in preparation for ci link check
([#869](#869))
([a78d03c](a78d03c))
* **prover:** Update shivini
([#915](#915))
([f141a00](f141a00))
* **witness-generator:** Update era-zkevm_test_harness
([#912](#912))
([c03c2e3](c03c2e3))
* **witness-generator:** Update zkevm_test_harness
([#930](#930))
([16fdcff](16fdcff))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit that referenced this pull request Jan 30, 2024
@zksync-era-bot
chore(main): release core 20.2.0 (#934)
0759fb7 
🤖 I have created a release *beep* *boop*
---


##
[20.2.0](core-v20.1.0...core-v20.2.0)
(2024-01-30)


### Features

* added unauthenticated version of gcs object store
([#916](#916))
([638a813](638a813))
* Adding EN snapshots applier
([#882](#882))
([0d2ba09](0d2ba09))
* consensus component config for main node and external node
([#881](#881))
([1aed8de](1aed8de))
* **en:** Make ENs detect reorgs earlier
([#964](#964))
([b043cc8](b043cc8))
* **en:** Restore state keeper storage from snapshot
([#885](#885))
([a9553b5](a9553b5))
* protobuf-generated json configs for the main node (BFT-371)
([#458](#458))
([f938314](f938314))
* Remove zkevm_test_harness public reexport from zksync_types
([#929](#929))
([dd1a35e](dd1a35e))
* **state-keeper:** track the time that individual transactions spend in
mempool ([#941](#941))
([fa45aa9](fa45aa9))
* **vm:** detailed circuit statistic
([#845](#845))
([a20af60](a20af60))
* **vm:** Support tracers for old vm
([#926](#926))
([9fc2d95](9fc2d95))


### Bug Fixes

* **api:** Order transaction traces in `debug_traceBlock*` methods
([#924](#924))
([5918ef9](5918ef9))
* **db:** Make `get_expected_l1_batch_timestamp()` more efficient
([#963](#963))
([7334679](7334679))
* **db:** Make `snapshot_recovery` migration backward-compatible
([#961](#961))
([e756762](e756762))
* **zksync_types:** Update SerializationTransactionError::OversizedData
description
([#949](#949))
([c95f3ee](c95f3ee))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm-zk mm-zk mm-zk approved these changes

@EmilLuta EmilLuta Awaiting requested review from EmilLuta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@popzxc @mm-zk