fix(vm): Save empty bootloader memory for batches with ancient vms #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
requested review from
StanislavBreadless,
RomanBrodetski and
perekopskiy
Deniallugo
force-pushed
the
deniallugo-fix-final-bootloader-memory-for-old-batches
branch
2 times, most recently
from
c124ddc
to
6d39baa
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-fix-final-bootloader-memory-for-old-batches
branch
from
6d39baa
to
b26b365
Compare
RomanBrodetski
approved these changes
Feb 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
) ## What ❔ Save empty data to the database if bootloader memory doesn't exists. It's possible for old vms ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`. Signed-off-by: Danil <deniallugo@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Deniallugo
deleted the
deniallugo-fix-final-bootloader-memory-for-old-batches
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
🤖 I have created a release *beep* *boop* --- ## [20.5.0](core-v20.4.0...core-v20.5.0) (2024-02-02) ### Features * **merkle-tree:** Do not wait for tree initialization when starting node ([#992](#992)) ([fdbfcb1](fdbfcb1)) ### Bug Fixes * added consensus column back ([#986](#986)) ([b9b48d4](b9b48d4)) * get_block_receipts test ([#989](#989)) ([c301359](c301359)) * **vm:** Save empty bootloader memory for batches with ancient vms ([#991](#991)) ([af7f64f](af7f64f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Save empty data to the database if bootloader memory doesn't exists.
It's possible for old vms
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.